Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-637 UI Consistency: Topology styling #224

Merged
merged 3 commits into from
Nov 16, 2022
Merged

NETOBSERV-637 UI Consistency: Topology styling #224

merged 3 commits into from
Nov 16, 2022

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Nov 7, 2022 •
edited
Loading

Blocked by #215 & #222

  • Filtering color
    image

  • Decorators sizing / placement
    image
    Old "info" decorator has been removed in favor of side panel for better UX

  • Decorators tooltips
    image
    image
    image

  • Node background fix on dark theme
    image

  • Edges barely visible on dark theme
    image

  • Unknown / external square shape
    image

@openshift-ci
Copy link

openshift-ci bot commented Nov 7, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jpinsonneau jpinsonneau changed the title UI Consistency: Topology styling NETOBSERV-637 UI Consistency: Topology styling Nov 7, 2022
@jpinsonneau jpinsonneau marked this pull request as ready for review November 9, 2022 11:26
@Amoghrd
Copy link
Contributor

Amoghrd commented Nov 10, 2022

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 10, 2022
@github-actions
Copy link

New image: ["quay.io/netobserv/network-observability-console-plugin:4bb27c8"]. It will expire after two weeks.

@jotak
Copy link
Member

jotak commented Nov 16, 2022

awesome, looks much better with the dark theme!
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 16, 2022
@openshift-ci openshift-ci bot removed the lgtm label Nov 16, 2022
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 16, 2022
@jpinsonneau
Copy link
Contributor Author

awesome, looks much better with the dark theme! /lgtm

👍 I have rebased for merge. No changes on my side

@jotak
Copy link
Member

jotak commented Nov 16, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 16, 2022
@openshift-ci openshift-ci bot removed the lgtm label Nov 16, 2022
@jotak
Copy link
Member

jotak commented Nov 16, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 16, 2022
@jpinsonneau
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5f1efc4 into netobserv:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotak jotak Awaiting requested review from jotak

@OlivierCazade OlivierCazade Awaiting requested review from OlivierCazade

Assignees

@jotak jotak

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpinsonneau @Amoghrd @jotak @openshift-merge-robot